git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] Don't crash during repack of a reflog with pruned commits.

From
Jakub Narebski <jnareb@gmail.com>
Date
Dec 22, 2006, 01:18 UTC
Message-ID
<emfbk4$f45$1@sea.gmane.org>
In-Reply-To
<20061222010018.GB14773@spearce.org>
Shawn Pearce wrote:
Show 13 quoted lines
> Junio C Hamano <junkio@cox.net> wrote:
>> "Shawn O. Pearce" <spearce@spearce.org> writes:
>> 
>>> If the user has been using reflog for a long time (e.g. since its
>>> introduction) then it is very likely that an existing branch's
>>> reflog may still mention commits which have long since been pruned
>>> out of the repository.
>> 
>> I've thought about this issue when I did the repack/prune; my
>> take on this was you should prune reflog first then repack.
> 
> OK, but we should suggest that to the user rather than just
> cryptically saying 'fatal: bad object refs/heads/build'.

I still think it is a good idea to allow user (experienced user) to set to not consider reflog for saving. Especially that there exist repositories which have reflogs with long pruned commits, and it would be nice to preserve the reflog info, even if some of information is not available.

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
Previous: Shawn PearceNext: Shawn Pearce
Message 5 of 9 in “Introduce a global level warn() function.”
  1. 2/3 Introduce a global level warn() function.Shawn O. Pearce, Dec 22, 2006
  2. 3/3 Don't crash during repack of a reflog with pruned commits.Shawn O. Pearce, Dec 22, 2006
  3. Junio C HamanoDec 22, 2006
  4. Shawn PearceDec 22, 2006
  5. Jakub NarebskiDec 22, 2006
  6. Shawn PearceDec 22, 2006
  7. Shawn PearceDec 22, 2006
  8. Junio C HamanoDec 22, 2006
  9. Shawn PearceDec 22, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.