git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] Don't crash during repack of a reflog with pruned commits.

From
Shawn Pearce <spearce@spearce.org>
Date
Dec 22, 2006, 00:56 UTC
Message-ID
<20061222005606.GA14773@spearce.org>
In-Reply-To
<20061222004906.GC14789@spearce.org>
"Shawn O. Pearce" <spearce@spearce.org> wrote:
Show 11 quoted lines
> If the user has been using reflog for a long time (e.g. since its
> introduction) then it is very likely that an existing branch's
> reflog may still mention commits which have long since been pruned
> out of the repository.
> 
> Rather than aborting with a very useless error message during
> git-repack, pack as many valid commits as we can get from the
> reflog and let the user know that the branch's reflog contains
> already pruned commits.  A future 'git reflog expire' (or whatever
> it finally winds up being called) can then be performed to expunge
> those reflog entries.

If its not obvious from the patch, this doesn't entirely fix the problem.

Just because the commit has not been pruned does not mean that a blob or tree referenced by that commit has not been pruned. Right now I am missing 1 blob and cannot repack because of it.

At least with this series of 3 patches the error message resulting from this one missing blob is clearer.

-- 
Shawn.
Previous: Shawn PearceNext: Junio C Hamano
Message 7 of 9 in “Introduce a global level warn() function.”
  1. 2/3 Introduce a global level warn() function.Shawn O. Pearce, Dec 22, 2006
  2. 3/3 Don't crash during repack of a reflog with pruned commits.Shawn O. Pearce, Dec 22, 2006
  3. Junio C HamanoDec 22, 2006
  4. Shawn PearceDec 22, 2006
  5. Jakub NarebskiDec 22, 2006
  6. Shawn PearceDec 22, 2006
  7. Shawn PearceDec 22, 2006
  8. Junio C HamanoDec 22, 2006
  9. Shawn PearceDec 22, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.