git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] Don't crash during repack of a reflog with pruned commits.

From
Shawn Pearce <spearce@spearce.org>
Date
Dec 22, 2006, 01:23 UTC
Message-ID
<20061222012344.GD14773@spearce.org>
In-Reply-To
<emfbk4$f45$1@sea.gmane.org>
Jakub Narebski <jnareb@gmail.com> wrote:
Show 5 quoted lines
> I still think it is a good idea to allow user (experienced user)
> to set to not consider reflog for saving. Especially that there
> exist repositories which have reflogs with long pruned commits,
> and it would be nice to preserve the reflog info, even if some of
> information is not available.

In my humble opinion there is *no* value in a reflog whose commits are "corrupt" (due to missing commit object or missing tree/blob it references) as you cannot get that commit back. And its hard to get any other data from it.

My local git.git repository got killed during a repack because I was missing 1 blob (an old version of builtin-blame.c) from Junio's pu branch. Apparently I had a reflog on that tracking branch which went back pretty far and although the commits in that log were still available, the blob wasn't.

-- 
Shawn.
Previous: Jakub NarebskiNext: Shawn Pearce
Message 6 of 9 in “Introduce a global level warn() function.”
  1. 2/3 Introduce a global level warn() function.Shawn O. Pearce, Dec 22, 2006
  2. 3/3 Don't crash during repack of a reflog with pruned commits.Shawn O. Pearce, Dec 22, 2006
  3. Junio C HamanoDec 22, 2006
  4. Shawn PearceDec 22, 2006
  5. Jakub NarebskiDec 22, 2006
  6. Shawn PearceDec 22, 2006
  7. Shawn PearceDec 22, 2006
  8. Junio C HamanoDec 22, 2006
  9. Shawn PearceDec 22, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.