Re: [PATCH 3/5] get_shallow_commits: Avoid memory leak if a commit has been reached already.

From: Anand Kumria <wildfire@progsoc.org>
Date: Nov 25, 2006, 17:22 UTC
Message-ID: <ek9u4f$vmk$1@sea.gmane.org>
In-Reply-To: <87slg8uc0l.fsf@wine.dyndns.org>

On Fri, 24 Nov 2006 15:58:50 +0100, Alexandre Julliard wrote:

Show 18 quoted lines

> Signed-off-by: Alexandre Julliard <julliard@winehq.org>
> ---
>  shallow.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/shallow.c b/shallow.c
> index 2db1dc4..3d53d17 100644
> --- a/shallow.c
> +++ b/shallow.c
> @@ -60,7 +60,9 @@ struct commit_list *get_shallow_commits(
>  					commit = NULL;
>  					continue;
>  				}
> -				commit->util = xcalloc(1, sizeof(int));
> +				if (!commit->util)
> +					commit->util = xmalloc(sizeof(int));
> +				*(int *)commit->util = 0;
>  				cur_depth = 0;

Hi,

Any reason you didn't do:

if (!commit->util)
	commit->util = xcalloc(1, sizeof(int));

That would seem to be the same.

Regards, Anand