git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/5] get_shallow_commits: Avoid memory leak if a commit has been reached already.

From
AJAlexandre Julliard <julliard@winehq.org>
Date
Nov 24, 2006, 14:58 UTC
Message-ID
<87slg8uc0l.fsf@wine.dyndns.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
---
 shallow.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/shallow.c b/shallow.c
index 2db1dc4..3d53d17 100644
--- a/shallow.c
+++ b/shallow.c
@@ -60,7 +60,9 @@ struct commit_list *get_shallow_commits(
 					commit = NULL;
 					continue;
 				}
-				commit->util = xcalloc(1, sizeof(int));
+				if (!commit->util)
+					commit->util = xmalloc(sizeof(int));
+				*(int *)commit->util = 0;
 				cur_depth = 0;
 			} else {
 				commit = (struct commit *)
-- 
1.4.4.1.ga335e

-- 
Alexandre Julliard
Next: Anand Kumria
Message 1 of 5 in “get_shallow_commits: Avoid memory leak if a commit has been reached already.”
  1. 3/5 get_shallow_commits: Avoid memory leak if a commit has been reached already.Alexandre Julliard, Nov 24, 2006
  2. Anand KumriaNov 25, 2006
  3. Johannes SchindelinNov 25, 2006
  4. Junio C HamanoNov 25, 2006
  5. Johannes SchindelinNov 25, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.