Re: [PATCH 3/5] get_shallow_commits: Avoid memory leak if a commit has been reached already.
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Nov 25, 2006, 23:36 UTC
- Message-ID
- <Pine.LNX.4.63.0611260033410.30004@wbgn013.biozentrum.uni-wuerzburg.de>
- In-Reply-To
- <7v1wnr2twq.fsf@assigned-by-dhcp.cox.net>
Hi,
On Sat, 25 Nov 2006, Junio C Hamano wrote:
> I think you could pretend the commit->util field to be of some kind of > int and avoid the allocation altogether ;-).
I actually thought about that, and found it too dangerous. But of course, since we need at least a 32-bit architecture, chances are very high that a pointer is castable to an int.
Ciao, Dscho