Re: [PATCH 1/2] Revert "fetch-pack: add a deref_without_lazy_fetch_extended()"

From: Josh Steadmon <steadmon@google.com>
Date: Oct 30, 2024, 21:22 UTC
Message-ID: <ejrw5wyxianyz5wkwvfw4dhssg23lmxlhgbo7bbzwif742uk5j@rni2fojw6py7>
In-Reply-To: <4dea8933cf05a5020da7d78c088f4b091100952c.1730235646.git.jonathantanmy@google.com>

On 2024.10.29 14:11, Jonathan Tan wrote:

Show 10 quoted lines

> This reverts commit a6e65fb39caf18259c660c1c7910d5bf80bc15cb.
> 
> The commit message of that commit mentions that the new function "will
> be used for the bundle-uri client in a subsequent commit", but it seems
> that eventually it wasn't used.
> 
> Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
> ---
>  fetch-pack.c | 25 +++++++------------------
>  1 file changed, 7 insertions(+), 18 deletions(-)

Nit: can you mention in the commit description that this cleanup
simplifies a later patch to detect a case of repo corruption?

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.