Re: [External] Re: [PATCH v2 2/2] fetch-pack: warn if in commit graph but not obj db

From: Jonathan Tan <jonathantanmy@google.com>
Date: Nov 1, 2024, 17:46 UTC
Message-ID: <20241101174646.685790-1-jonathantanmy@google.com>
In-Reply-To: <CAKgqsWWo2r37nsxeYErXjEgrSepBgFpdde9bXuYDTfu4MC3+Ag@mail.gmail.com>

Han Xin <hanxin.hx@bytedance.com> writes:

Show 6 quoted lines

> Although the scenario I faked in t/t5330-no-lazy-fetch-with-commit-graph.sh
> usually does not occur, if we are unfortunate enough to encounter this issue,
> I hope it can automatically fix the problem as much as possible without
> relying on me to take an extra action.
> 
> Thanks.

Note that unfortunately the user will still need to take an extra action.

My goal at first was to try to teach Git to fetch the commit (in the commit graph file but not in the object DB) anyway, so that (as you said) the problem will fix itself, but that requires not only a change in the part of the code that emits "want", but also the part that emits "have" (the fetch negotiation code). At that point, I decided that it's better to stop early and warn the user (it was not a fatal error in the original version of the code, but I have changed it).