git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 0/2] When fetching, die if in commit graph but not obj db

From
JTJonathan Tan <jonathantanmy@google.com>
Date
Nov 5, 2024, 19:24 UTC
Message-ID
<cover.1730833754.git.jonathantanmy@google.com>
In-Reply-To
<cover.1730235646.git.jonathantanmy@google.com>
Changes: the commit message title of the second patch, and a change from
grep to test_grep.
Jonathan Tan (2):
  Revert "fetch-pack: add a deref_without_lazy_fetch_extended()"
  fetch-pack: die if in commit graph but not obj db
 fetch-pack.c                               | 42 +++++++++++-----------
 t/t5330-no-lazy-fetch-with-commit-graph.sh |  4 +--
 2 files changed, 24 insertions(+), 22 deletions(-)
Range-diff against v2:
1:  34e87b8388 = 1:  34e87b8388 Revert "fetch-pack: add a deref_without_lazy_fetch_extended()"
2:  a35e386a0e ! 2:  c92b2c9e50 fetch-pack: warn if in commit graph but not obj db
    @@ Metadata
     Author: Jonathan Tan <jonathantanmy@google.com>
     
      ## Commit message ##
    -    fetch-pack: warn if in commit graph but not obj db
    +    fetch-pack: die if in commit graph but not obj db
     
         When fetching, there is a step in which sought objects are first checked
         against the local repository; only objects that are not in the local
    @@ t/t5330-no-lazy-fetch-with-commit-graph.sh: test_expect_success 'fetch any commi
     -	GIT_TRACE="$(pwd)/trace.txt" \
     +	test_must_fail env GIT_TRACE="$(pwd)/trace.txt" \
      		git -C with-commit-graph fetch origin $anycommit 2>err &&
    - 	! grep "fatal: promisor-remote: unable to fork off fetch subprocess" err &&
    +-	! grep "fatal: promisor-remote: unable to fork off fetch subprocess" err &&
    ++	test_grep ! "fatal: promisor-remote: unable to fork off fetch subprocess" err &&
      	grep "git fetch origin" trace.txt >actual &&
    + 	test_line_count = 1 actual
    + '
-- 
2.47.0.277.g8800431eea-goog
Previous: Josh SteadmonNext: Jonathan Tan
Message 35 of 38 in “promisor-remote: always JIT fetch with --refetch”
  1. promisor-remote: always JIT fetch with --refetchEmily Shaffer, Oct 3, 2024
  2. Junio C HamanoOct 6, 2024
  3. Robert CoupOct 7, 2024
  4. Junio C HamanoOct 7, 2024
  5. Emily ShafferOct 11, 2024
  6. Junio C HamanoOct 11, 2024
  7. fetch-pack: don't mark COMPLETE unless we have the full objectEmily Shaffer, Oct 23, 2024
  8. Emily ShafferOct 23, 2024
  9. Taylor BlauOct 23, 2024
  10. Jonathan TanOct 28, 2024
  11. 0/2 When fetching, warn if in commit graph but not obj dbJonathan Tan, Oct 29, 2024
  12. 1/2 Revert "fetch-pack: add a deref_without_lazy_fetch_extended()"Jonathan Tan, Oct 29, 2024
  13. Josh SteadmonOct 30, 2024
  14. 2/2 fetch-pack: warn if in commit graph but not obj dbJonathan Tan, Oct 29, 2024
  15. Josh SteadmonOct 30, 2024
  16. Jonathan TanOct 31, 2024
  17. Taylor BlauOct 31, 2024
  18. Jonathan TanOct 31, 2024
  19. Taylor BlauNov 1, 2024
  20. Jonathan TanNov 1, 2024
  21. Josh SteadmonOct 30, 2024
  22. 0/2 When fetching, die if in commit graph but not obj dbJonathan Tan, Oct 31, 2024
  23. 1/2 Revert "fetch-pack: add a deref_without_lazy_fetch_extended()"Jonathan Tan, Oct 31, 2024
  24. 2/2 fetch-pack: warn if in commit graph but not obj dbJonathan Tan, Oct 31, 2024
  25. Junio C HamanoNov 1, 2024
  26. Junio C HamanoNov 1, 2024
  27. Han XinNov 1, 2024
  28. Jonathan TanNov 1, 2024
  29. Jonathan TanNov 1, 2024
  30. Junio C HamanoNov 2, 2024
  31. Jonathan TanNov 1, 2024
  32. Taylor BlauNov 1, 2024
  33. Jonathan TanNov 1, 2024
  34. Josh SteadmonOct 31, 2024
  35. 0/2 When fetching, die if in commit graph but not obj dbJonathan Tan, Nov 5, 2024
  36. 1/2 Revert "fetch-pack: add a deref_without_lazy_fetch_extended()"Jonathan Tan, Nov 5, 2024
  37. 2/2 fetch-pack: die if in commit graph but not obj dbJonathan Tan, Nov 5, 2024
  38. Junio C HamanoNov 6, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.