Re: [PATCH] gitweb: tree view: eliminate redundant "blob"
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Sep 26, 2006, 08:54 UTC
- Message-ID
- <efapsl$e65$1@sea.gmane.org>
- In-Reply-To
- <20060926053816.54951.qmail@web31815.mail.mud.yahoo.com>
Luben Tuikov wrote:
Show 10 quoted lines
> Binary and non-binary blobs: > > The "list" table element of tree view is identical > to the "blob" link part of the link table element. > I.e. clicking on "blob" is identical to clicking on > the entry itself. > > Thus, eliminate "blob" from being shown -- the user > can get identical result by simply clicking on the > entry itself.
I'd rather not. The fact that the file name and tree name is link, and the fact that commit title and tag title is link is a _convenience_. Not always it is visible (without mouseover) that it is link. And it is _not_ visible in the case of files!
And for example for commits and heads there are two possible views, commit and commitdiff for commit, shortlog and log for head, of which we arbitrary chose one for the subject link. So in that case the additional self link is needed. I'd rather have both. And for consistency I'd rather always have visible form default self link/
I'd rather have additional link, than cause confusion to the users. Perhaps we could separate the self link ("blob" for files, "tree" for directories) into separate column?
Besides, you have to mouse over the name of file, or name of directory to see to what view it would lead on.
Nak.
-- Jakub Narebski Warsaw, Poland ShadeHawk on #git