Re: [PATCH] gitweb: tree view: eliminate redundant "blob"

From: Petr Baudis <pasky@suse.cz>
Date: Sep 26, 2006, 16:07 UTC
Message-ID: <20060926160729.GH20017@pasky.or.cz>
In-Reply-To: <efapsl$e65$1@sea.gmane.org>

Dear diary, on Tue, Sep 26, 2006 at 10:54:49AM CEST, I got a letter where Jakub Narebski <jnareb@gmail.com> said that...

> I'd rather not. The fact that the file name and tree name is link,
> and the fact that commit title and tag title is link is a _convenience_.
> Not always it is visible (without mouseover) that it is link.
> And it is _not_ visible in the case of files!

Then that should be fixed.

And directories should have trailing slash in their name in the tree listing, for people with non-UNIX background who don't understand the ls -l like output.

> And for example for commits and heads there are two possible
> views, commit and commitdiff for commit, shortlog and log for head,
> of which we arbitrary chose one for the subject link. So in that
> case the additional self link is needed. I'd rather have both.

For commits and heads, I agree. But that's not what this patch does.

> And for consistency I'd rather always have visible form default
> self link/

A parse error kicked me off here, sorry.

(I'm personally kind of ambivalent to the change.)

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
#!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj
$/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1
lK[d2%Sa2/d0$^Ixp"|dc`;s/\W//g;$_=pack('H*',/((..)*)$/)