Re: [PATCH] gitweb: tree view: eliminate redundant "blob"

From: Luben Tuikov <ltuikov@yahoo.com>
Date: Sep 26, 2006, 21:32 UTC
Message-ID: <20060926213236.79160.qmail@web31815.mail.mud.yahoo.com>
In-Reply-To: <efc2no$eti$2@sea.gmane.org>

--- Jakub Narebski <jnareb@gmail.com> wrote:

Show 10 quoted lines

> This is example of where forefront has it wrong. I'm all for "list" entry
> to be link to default view, but I'm all against removing clearly marked
> link to "plain"/"tree" view.
> 
> And "invisible links" _especially_ if the link is not convenience only
> (i.e. it is not provided clearly as link somewhere else) is so called
> "mystery meat navigation" and is one of the most common mistakes in
> web development.
> 
> And is not as if "plain |" takes much space...

I think you would agree that gitweb is quite different than what is commonly defined as "mystery meat navigation".

Gitweb is very well thought out interface, and self-contained. There isn't much pondering about what and where to click, have newbies too.

Think about the removal of the redundant "blob" and "tree" as database schema normalization if you will. The redundancy is so well defined that even applying a simple algorithm to gitweb.perl will discover it.

Either that or you can think of it as "shortening" the line.
Wlg, suppose that I have a file called "blob" and a directory
called "tree":
    mode blob    blob | blame | history | raw
    mode tree    tree | history
Is equivalent to
    mode blob    blame | history | raw
    mode tree    history
For any name "blob" and any name "tree".

Plus the code (gitweb.perl) has less redundancy and overhead.

     Luben