Re: [PATCH 2/9] gitweb: Separate ref parsing in git_get_refs_list into parse_ref
Show 5 quoted lines
> Jakub Narebski <jnareb@gmail.com> writes:
>
>> Note that for each ref there are usually two calls to git subroutines:
>> first to get the type of ref, second to parse ref if ref is of commit
>> or tag type.
Show 8 quoted lines
>> +# parse ref from ref_file, given by ref_id, with given type
>> +sub parse_ref {
>> + my $ref_file = shift;
>> + my $ref_id = shift;
>> + my $type = shift || git_get_type($ref_id);
>
> This git_get_type() is additional from the original.
> Future-proofing yourself for other new callers?--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
Jakub Narebski <jnareb@gmail.com>