Re: [PATCH 8/9] gitweb: True fix: Support for the standard mime.types map in gitweb
- From
Junio C Hamano <junkio@cox.net>
- Date
- Aug 15, 2006, 00:33 UTC
- Message-ID
- <7vlkpqbzxx.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <200608140216.34150.jnareb@gmail.com>
Jakub Narebski <jnareb@gmail.com> writes:
Show 6 quoted lines
> True fix for error in mimetype_guess, error introduced in original commit > 2d00737489b8c61ed616b261c7c9bd314e2b0b41 and later fixed temporarily > by commenting out the line that caused error in commit > 57bd4d3523efecf60197040cad34154aff4ddf80. > > Gitweb now supports mime.types map $mimetypes_file relative to project.
Care to explain what that commenting out was about?
Show 8 quoted lines
> if ($mimetypes_file) {
> my $file = $mimetypes_file;
> - #$file =~ m#^/# or $file = "$projectroot/$path/$file";
> + if ($file !~ m!^/!) { # if it is relative path
> + # it is relative to project
> + $file = "$projectroot/$project/$file";
> + }
> $mime = mimetype_guess_file($filename, $file);Are $project and $file always defined when we take this new codepath?