From: Jakub Narebski <jnareb@gmail.com>
Date: Tue, 15 Aug 2006 16:18:43 GMT
Subject: Re: [PATCH 2/9] gitweb: Separate ref parsing in git_get_refs_list into parse_ref
Message-ID: <ebss3h$tgq$2@sea.gmane.org>
In-Reply-To: <7vu04ec04b.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano wrote:

> Jakub Narebski <jnareb@gmail.com> writes:
> 
>> Note that for each ref there are usually two calls to git subroutines:
>> first to get the type of ref, second to parse ref if ref is of commit
>> or tag type.

[...]  
>> +# parse ref from ref_file, given by ref_id, with given type
>> +sub parse_ref {
>> +    my $ref_file = shift;
>> +    my $ref_id = shift;
>> +    my $type = shift || git_get_type($ref_id);
> 
> This git_get_type() is additional from the original.
> Future-proofing yourself for other new callers?

Yes, just in case.

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git