Re: 2.10.0: git log --oneline prints gpg signatures in 4 lines

From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Sep 21, 2016, 15:05 UTC
Message-ID: <ebdb9974-9ab8-1e8a-f678-847a798f4c44@drmicha.warpmail.net>
In-Reply-To: <20160921155300.79252e68@labs-064.localdomain>

Leandro Lucarella venit, vidit, dixit 21.09.2016 15:53:

Show 31 quoted lines

> On Tue, 20 Sep 2016 19:15:33 -0400
> Jeff King <peff@peff.net> wrote:
> 
>> On Tue, Sep 20, 2016 at 05:09:54PM +0200, Leandro Lucarella wrote:
>>
>>> Hi, starting from 2.10.0 I noticed that when using git log
>>> --oneline, if commits are signed with GPG, now the signatures are
>>> printed too, and it takes 3 lines for the signature information + 1
>>> line for the title of the commit, so suddenly --oneline became
>>> --fourline :)
>>>
>>> Is this really intended?
>>
>> I don't think anything has changed here in 2.10. Running "git log
>> --oneline --show-signature" has _always_ been horribly ugly. However,
>> 2.10 did introduce the "log.showsignature" config, which makes "git
>> log --oneline" pretty unusable when it is enabled. Ditto for
>> one-liner uses of "--format".
>>
>> I think we should probably ignore the config entirely when using any
>> of the one-liner formats (and I'd include --format, too, even though
>> it can sometimes be multi-line; it already has %GG to include that
>> information as appropriate).
> 
> Woops! Definitely it shouldn't be added when --format is used, this is
> also breaking some scripts I have using git log --format to get some
> information about commits, and GPG information is being output even
> when there is anything about GPG requested in the chosen format.
> 
> I guess I will disable log.showsignatures for now... :(
>

I guess that's one of the reasons why I didn't like that config option to begin with. There's a flood of these config "convenience" options lately where we have to special case for scripting... Aliases must have become old school or something.

Note that "git log --show-notes", "git log --oneline --raw", "git log --oneline -p" and similar are not "one line" either. So "--show-signature" behaves just like all others.

git log --format="%h %G? %s"

or a colored version thereof may be what you want to alias as "log1" or such.

Cheers, Michael