Re: 2.10.0: git log --oneline prints gpg signatures in 4 lines

From: Leandro Lucarella <leandro.lucarella@sociomantic.com>
Date: Sep 21, 2016, 13:53 UTC
Message-ID: <20160921155300.79252e68@labs-064.localdomain>
In-Reply-To: <20160920231533.fxcdjgphz25hnbxt@sigill.intra.peff.net>

On Tue, 20 Sep 2016 19:15:33 -0400 Jeff King <peff@peff.net> wrote:

Show 20 quoted lines

> On Tue, Sep 20, 2016 at 05:09:54PM +0200, Leandro Lucarella wrote:
> 
> > Hi, starting from 2.10.0 I noticed that when using git log
> > --oneline, if commits are signed with GPG, now the signatures are
> > printed too, and it takes 3 lines for the signature information + 1
> > line for the title of the commit, so suddenly --oneline became
> > --fourline :)
> > 
> > Is this really intended?
> 
> I don't think anything has changed here in 2.10. Running "git log
> --oneline --show-signature" has _always_ been horribly ugly. However,
> 2.10 did introduce the "log.showsignature" config, which makes "git
> log --oneline" pretty unusable when it is enabled. Ditto for
> one-liner uses of "--format".
> 
> I think we should probably ignore the config entirely when using any
> of the one-liner formats (and I'd include --format, too, even though
> it can sometimes be multi-line; it already has %GG to include that
> information as appropriate).

Woops! Definitely it shouldn't be added when --format is used, this is also breaking some scripts I have using git log --format to get some information about commits, and GPG information is being output even when there is anything about GPG requested in the chosen format.

I guess I will disable log.showsignatures for now... :(

-- 
Leandro Lucarella
Technical Development Lead
Sociomantic Labs GmbH <http://www.sociomantic.com>