Re: 2.10.0: git log --oneline prints gpg signatures in 4 lines

From: Leandro Lucarella <leandro.lucarella@sociomantic.com>
Date: Sep 21, 2016, 10:24 UTC
Message-ID: <20160921122454.2a736dea@labs-064.localdomain>
In-Reply-To: <20160920231533.fxcdjgphz25hnbxt@sigill.intra.peff.net>

On Tue, 20 Sep 2016 19:15:33 -0400 Jeff King <peff@peff.net> wrote:

Show 15 quoted lines

> On Tue, Sep 20, 2016 at 05:09:54PM +0200, Leandro Lucarella wrote:
> 
> > Hi, starting from 2.10.0 I noticed that when using git log
> > --oneline, if commits are signed with GPG, now the signatures are
> > printed too, and it takes 3 lines for the signature information + 1
> > line for the title of the commit, so suddenly --oneline became
> > --fourline :)
> > 
> > Is this really intended?
> 
> I don't think anything has changed here in 2.10. Running "git log
> --oneline --show-signature" has _always_ been horribly ugly. However,
> 2.10 did introduce the "log.showsignature" config, which makes "git
> log --oneline" pretty unusable when it is enabled. Ditto for
> one-liner uses of "--format".

Right! Now I remember, I changed my configuration when I read the release notes, before I upgraded. Now that I did upgrade I'm seeing the results.

Anyway, yeah, using the new configuration makes --oneline pretty unusable, so ignoring that option for --oneline seems like a good idea.

Show 8 quoted lines

> I think we should probably ignore the config entirely when using any
> of the one-liner formats (and I'd include --format, too, even though
> it can sometimes be multi-line; it already has %GG to include that
> information as appropriate).
> 
> Another option would be to somehow represent the signature information
> in the --oneline output, but I think I'd rather leave that for people
> to experiment with using "--format".

I think it might be nice to show the information in one line in a ver succinct way, like just showing a green unicode check mark (✓) or a red cross mark (❌) if it failed (or just colour the commit subject in green/red if a signature is present and is passing/failing).

Thanks!

-- 
Leandro Lucarella
Technical Development Lead
Sociomantic Labs GmbH <http://www.sociomantic.com>