Re: [PATCH] gitweb.cgi: Customization

From: Jakub Narebski <jnareb@gmail.com>
Date: Aug 2, 2006, 17:34 UTC
Message-ID: <eaqnm8$gni$1@sea.gmane.org>
In-Reply-To: <20060802165333.GA22726@coredump.intra.peff.net>

Jeff King wrote:

Show 18 quoted lines

> On Wed, Aug 02, 2006 at 11:23:22AM -0500, Jon Loeliger wrote:
> 
>> With this "params in config.mk" approach, I have to
>> run it multiple times, once for each web server I run.
>>
>> I _really_ would prefer an "include from ." feature
>> where I can place the specific gitweb_config.pm parts
>> in the same directory where gitweb.{pl,cgi} is installed.
> 
> Why don't we have sensible compile-time defaults that can be overridden
> by a run-time config file like every other sane program? For those who
> are opposed to the run-time config, they can simply not have a config
> file.
> 
> See the (completely untested) patch below. Obviously the config file
> name has to be set at build time. However, since it is interpolated by
> perl, you can do clever things like:
>   /etc/gitweb/$ENV{MY_VIRTUAL_HOST}.pl

Besides, we can use _relative_ paths.

I like this proposal the best.

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git