Re: [PATCH] gitweb.cgi: Customization

From: Luben Tuikov <ltuikov@yahoo.com>
Date: Aug 1, 2006, 22:53 UTC
Message-ID: <20060801225352.26998.qmail@web31801.mail.mud.yahoo.com>
In-Reply-To: <7vfygg14sq.fsf@assigned-by-dhcp.cox.net>

--- Junio C Hamano <junkio@cox.net> wrote:

Show 8 quoted lines

> Luben Tuikov <ltuikov@yahoo.com> writes:
> 
> > Copy "Gitweb_customization.pm" to where your "gitweb.cgi" or
> > its link lives.
> 
> I do not think this is a good idea -- there may not be any harm
> done when http://site/cgi-bin/Gitweb_customization.pm is
> accessed, but this _does_ pollute the cgi-bin/ namespace.

As does "gitweb.css". Similarly, "gitweb.css"'s contents used to live in "gitweb.cgi" itself.

"Gitweb_customization.pm" doesn't necessarily need to live in "http://site/cgi-bin/", but anywhere in any path in @INC, i.e. such that it wouldn't be accessible from the outside world.

This method of customization seemed the least intrusive and easiest from re-deployment point of view.

    Luben