Re: [PATCH] gitweb.cgi: Customization
- From
Junio C Hamano <junkio@cox.net>
- Date
- Aug 1, 2006, 23:54 UTC
- Message-ID
- <7v8xm8xbaa.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <20060801225352.26998.qmail@web31801.mail.mud.yahoo.com>
Luben Tuikov <ltuikov@yahoo.com> writes:
> As does "gitweb.css". Similarly, "gitweb.css"'s contents > used to live in "gitweb.cgi" itself.
Not convincing argument. gitweb.css, and git-logo.png patch I think I will take, are meant to be fed to the http clients. They do not compare with the customization.pm which is not.
In any case, I think tweaking gitweb.cgi from Makefile like Martin Waitz did is as easy and clean for people who want to customize; it should just be the matter of defining the necessary params in config.mak.
I do not think there is much difference between any of the customization proposed so far (yours, Martin's and the one from Matthias Lederhofer) from functionality and ease-of-use point of view. They all try to make customization can be done in one place, and the difference is mostly of taste, so I'd just pick one from Martin.