Re: [PATCH 2] gitweb: Use list for of open for running git commands, thorougly.

From: Jakub Narebski <jnareb@gmail.com>
Date: Jul 31, 2006, 12:38 UTC
Message-ID: <eaktj9$df1$1@sea.gmane.org>
In-Reply-To: <eakrub$99t$1@sea.gmane.org>

Jakub Narebski wrote:

Show 17 quoted lines

> Jakub Narebski wrote:
> 
>> Junio C Hamano wrote:
>> 
>>> This, together with PATCH 6, seems to break "history" link.
>>> Visit a repository (summary page), click on "tree" on the second
>>> line, and click on "history" (on any blob or tree).
>> 
>> Strange... returning this part of git_history to previous version, i.e.
>> 
>>   open my $fd, "-|",
>>     "$GIT rev-list --full-history $hash_base -- \'$file_name\'";
>> 
>> still gives no history. Curious. Will examine that...
> 
> Curiouser and curiouser. It seems that somehow --full-history option 
> (which was never documented by the way) got lost somewhere.

Ooops. I've forgot that '--full-history' option was introduced after v1.4.0 (which I use).

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git