Re: [PATCH 2] gitweb: Use list for of open for running git commands, thorougly.

This, together with PATCH 6, seems to break "history" link. Visit a repository (summary page), click on "tree" on the second line, and click on "history" (on any blob or tree).

I might have made a merge mistake while squashing PATCH 2 and PATCH 6 into a single commit.

BTW, please be careful on trailing whitespaces.

I've wasted quite a lot of time yesterday just fixing up trailing whitespaces from your patches (although the first in your series was "whitespace cleanup" X-<).

I usually apply patches with whitespace=strip, unless there is a compelling reason not to (e.g. when the patch is to add a testcase of diff output which would inevitably have trailing whitespaces when a context contains an empty line), which means if you have a series of patches whose later patch updates lines with trailing whitespaces an earlier patch introduced the patch would not apply.