Re: [PATCH 2] gitweb: Use list for of open for running git commands, thorougly.

From: Jakub Narebski <jnareb@gmail.com>
Date: Jul 31, 2006, 12:10 UTC
Message-ID: <eakrub$99t$1@sea.gmane.org>
In-Reply-To: <eakqaj$530$1@sea.gmane.org>

Jakub Narebski wrote:

Show 12 quoted lines

> Junio C Hamano wrote:
> 
>> This, together with PATCH 6, seems to break "history" link.
>> Visit a repository (summary page), click on "tree" on the second
>> line, and click on "history" (on any blob or tree).
> 
> Strange... returning this part of git_history to previous version, i.e.
> 
>   open my $fd, "-|",
>     "$GIT rev-list --full-history $hash_base -- \'$file_name\'";
> 
> still gives no history. Curious. Will examine that...

Curiouser and curiouser. It seems that somehow --full-history option (which was never documented by the way) got lost somewhere.

  ~/git> git merge-base --all next HEAD
  688a75071490101dbc660e3304aafb7a13e28807

  ~/git> git log --full-history HEAD -- gitweb/test/file+plus+sign
  fatal: unrecognized argument: --full-history

(same with 'git rev-list --full-history HEAD -- gitweb/test/file+plus+sign', but it shows help instead of simply croaking like git-log).

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git