git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] scalar: add --no-tags option

From
Derrick Stolee <stolee@gmail.com>
Date
Sep 6, 2024, 19:46 UTC
Message-ID
<eaeb9ef8-d033-48ca-838c-25d1522e7afe@gmail.com>
In-Reply-To
<xmqqwmjoyfwh.fsf@gitster.g>
On 9/6/24 11:13 AM, Junio C Hamano wrote:
Show 10 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
>> None of these suggestions, in isolation or in conjunction, seem big enough
>> to me to warrant a new iteration; I just offer them here in case you want
>> to iterate on the patch. If you want to keep the patch as-is, I am totally
>> on board with that.
> 
> Everything other than "prefer repeated use of -C instead of a single
> subshell in there" (which I think worsens readability, even though
> it may save one process), I agree with your suggestions.

Thanks, both, for your review comments. v2 is on the way with these suggestions.

-Stolee
Previous: Junio C HamanoNext: Derrick Stolee via GitGitGadget
Message 6 of 7 in “scalar: add --no-tags option”
  1. scalar: add --no-tags optionDerrick Stolee via GitGitGadget, Sep 5, 2024
  2. Junio C HamanoSep 5, 2024
  3. Junio C HamanoSep 5, 2024
  4. Johannes SchindelinSep 6, 2024
  5. Junio C HamanoSep 6, 2024
  6. Derrick StoleeSep 6, 2024
  7. scalar: add --no-tags option to 'scalar clone'Derrick Stolee via GitGitGadget, Sep 6, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.