Re: [PATCH] scalar: add --no-tags option
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 6, 2024, 15:13 UTC
- Message-ID
- <xmqqwmjoyfwh.fsf@gitster.g>
- In-Reply-To
- <58ca5257-2e56-830c-c85f-79e4c9e80858@gmx.de>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> None of these suggestions, in isolation or in conjunction, seem big enough > to me to warrant a new iteration; I just offer them here in case you want > to iterate on the patch. If you want to keep the patch as-is, I am totally > on board with that.
Everything other than "prefer repeated use of -C instead of a single subshell in there" (which I think worsens readability, even though it may save one process), I agree with your suggestions.
Thanks.