From: Derrick Stolee <stolee@gmail.com>
Date: Fri, 06 Sep 2024 19:46:08 GMT
Subject: Re: [PATCH] scalar: add --no-tags option
Message-ID: <eaeb9ef8-d033-48ca-838c-25d1522e7afe@gmail.com>
In-Reply-To: <xmqqwmjoyfwh.fsf@gitster.g>

On 9/6/24 11:13 AM, Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
>> None of these suggestions, in isolation or in conjunction, seem big enough
>> to me to warrant a new iteration; I just offer them here in case you want
>> to iterate on the patch. If you want to keep the patch as-is, I am totally
>> on board with that.
> 
> Everything other than "prefer repeated use of -C instead of a single
> subshell in there" (which I think worsens readability, even though
> it may save one process), I agree with your suggestions.
Thanks, both, for your review comments. v2 is on the way with these
suggestions.

-Stolee