Re: [PATCH v3 00/15] Fix segfaults on settings given without a value
- From
Derrick Stolee <stolee@gmail.com>
- Date
- Nov 12, 2026, 14:25 UTC
- Message-ID
- <e8f6cbb1-8324-44e8-b703-d7a29ae7fa09@gmail.com>
- In-Reply-To
- <pull.2297.v3.git.1794437355.gitgitgadget@gmail.com>
On 11/11/2026 5:49 PM, Thomas Bachem via GitGitGadget wrote:
> A setting given without a value, as in "git -c foo.bar" or a bare "bar" > under "[foo]", is passed as NULL to the code that reads it. In these places > git does not check for that and segfaults:
...
Show 8 quoted lines
> Changes since v2: > > * Where an invalid value is ignored, a missing one now is too, with a > warning: remote.*.tagOpt (patch 6) and color.blame.repeatedLines (patch > 7). v2 rejected them (Phillip). > > * The test in patch 1 rebases onto HEAD~3 and checks the result with > test_commit_message (Phillip).
I reviewed the range-diff and found it reasonable.
But I was also happy with v2, so I look forward to Phillip chiming in on v3.
Thanks, -Stolee