Re: [PATCH v2 00/15] Fix segfaults on settings given without a value
- From
Thomas Bachem <mail@thomasbachem.com>
- Date
- Nov 10, 2026, 20:38 UTC
- Message-ID
- <CAA0xjtqx6qf0-zkeaM8+PJA34Obtj4H9073MTXryib=EvRVNKQ@mail.gmail.com>
- In-Reply-To
- <b68da114-ec84-402d-90ff-bdd1740d5338@gmail.com>
Phillip Wood <phillip.wood123@gmail.com> writes:
> There are several places where we now treat a NULL value as an error, > but we ignore empty or invalid values.
Thanks for reading the rest of the series too. Four of those places reject a missing value while an invalid one is ignored, and they are the only ones in the series. In v3, two of them will warn about a missing value and then ignore it, as patch 1 now does:
- remote.<name>.tagOpt (patch 6) - color.blame.repeatedLines (patch 7)
The other two, heuristic and creationToken in a bundle list (patch 14), keep the error. Stolee would rather make the bundle URI code stricter about malformed lists than more lenient.
Two more keep the error, as an invalid value there dies already: color.blame.highlightRecent in parse_color_fields(), and branch.<name>.mergeOptions on bad quoting or an unknown option. Junio has already explained why a missing mergeOptions shouldn't act like an empty one.
v3 also takes both of your suggestions for the test in patch 1.
Thomas