Re: [PATCH 00/15] Fix segfaults on settings given without a value
- From
Derrick Stolee <stolee@gmail.com>
- Date
- Nov 9, 2026, 13:42 UTC
- Message-ID
- <8c3480f5-1f34-4af5-bf68-60469dd83cfd@gmail.com>
- In-Reply-To
- <pull.2297.git.1794040967.gitgitgadget@gmail.com>
On 11/7/2026 3:42 AM, Thomas Bachem via GitGitGadget wrote:
> A setting given without a value, as in "git -c foo.bar" or a bare "bar" > under "[foo]", is passed as NULL to the code that reads it. In these places > git does not check for that and segfaults:
I read each patch, but commented (positively) on the ones where I was involved in creating the bug in the first place. Thank you for including a test in each case to prevent this from happening again.
The only suggestion I had for improving your patches is to include a more helpful error message when the bad data comes from a server- provided bundle list, but that isn't necessary for the bugfix. Also, such a custom response would look out of place with the rest of your patches. We can make that improvement later, if so desired.
Thanks, -Stolee