[PATCH v4 2/6] t7704-repack-cruft.sh: consolidate `write_blob()`
- From
Taylor Blau <me@ttaylorr.com>
- Date
- Mar 11, 2025, 00:21 UTC
- Message-ID
- <e7ebe6c460e2013d565dd87bc4bd584027e97590.1741648467.git.me@ttaylorr.com>
- In-Reply-To
- <cover.1741648467.git.me@ttaylorr.com>
The last commit moved a handful of tests from a different script into t7704, including one that relies on generating random blobs.
Incidentally, the original home of this test defined its own helper "write_blob" for doing so, which is identical in function to our "generate_random_blob" (and is slightly inferior to the latter, which cleans up after itself).
Rewrite the test that uses "write_blob" to no longer do so and then remove the function.
Signed-off-by: Taylor Blau <me@ttaylorr.com> --- t/t7704-repack-cruft.sh | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/t/t7704-repack-cruft.sh b/t/t7704-repack-cruft.sh index aa5d8913ae..5ce2648a29 100755 --- a/t/t7704-repack-cruft.sh +++ b/t/t7704-repack-cruft.sh @@ -552,11 +552,6 @@ test_expect_success 'cruft repack with no reachable objects' ' ) ' -write_blob () { - test-tool genrandom "$@" >in && - git hash-object -w -t blob in -} - find_pack () { for idx in $(ls $packdir/pack-*.idx) do @@ -575,8 +570,8 @@ test_expect_success 'cruft repack with --max-pack-size' ' test_commit base && # two cruft objects which exceed the maximum pack size - foo=$(write_blob foo 1048576) && - bar=$(write_blob bar 1048576) && + foo=$(generate_random_blob foo 1048576) && + bar=$(generate_random_blob bar 1048576) && test-tool chmtime --get -1000 \ "$objdir/$(test_oid_to_path $foo)" >foo.mtime && test-tool chmtime --get -2000 \
-- 2.49.0.rc2.6.g9a1eecd400