Re: [PATCH v2 0/2] pack-objects: freshen objects with multi-cruft packs

From: Taylor Blau <me@ttaylorr.com>
Date: Mar 5, 2025, 00:06 UTC
Message-ID: <Z8eVcn1wdnaV2VNH@nand.local>
In-Reply-To: <CABPp-BHv2_tgeQBKU6v4mnwU8_wOPHfPPRcpRQZ8wEP9P-HovA@mail.gmail.com>

On Tue, Mar 04, 2025 at 02:55:00PM -0800, Elijah Newren wrote:

> v2 looks good to me; though I'm curious if some wording improvement in
> the commit message might help in distinguishing between
> --max-cruft-size and --max-pack-size...and whether we want to provide
> any checks on the relative sizes of the two.

Thanks for the review! :-)

--max-cruft-size and --max-pack-size are the same thing from pack-objects' perspective; the two flags exist at the repack level in case you want to set a different maximum pack size for cruft- and non-cruft packs.

Both end up as a --max-pack-size value when repack invokes pack-objects for the cruft and non-cruft case.

Thanks, Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.