Re: [RFC PATCH] send-email: allow fixing the cover letter subject

From: Marvin Häuser <mhaeuser@posteo.de>
Date: Aug 25, 2021, 06:31 UTC
Message-ID: <e781b15c-8c59-9827-b052-ebe971b01cad@posteo.de>
In-Reply-To: <CAPUEspgmKPhbPGs+ujy7KVJCyNxS95ph2Dwvd7A7cH2J0em20g@mail.gmail.com>

On 24/08/2021 18:11, Carlo Arenas wrote:

Show 13 quoted lines

> On Tue, Aug 24, 2021 at 8:19 AM Marvin Häuser <mhaeuser@posteo.de> wrote:
>> On 24/08/2021 13:41, Carlo Marcelo Arenas Belón wrote:
>>> @@ -1719,7 +1719,6 @@ sub process_file {
>>>        @xh = ();
>>>        my $input_format = undef;
>>>        my @header = ();
>>> -     $subject = $initial_subject;
>> This change from my patch is still controversial, and I'd rather not
>> submit the addition if it's immediately removed again.
>> Why are you dropping it here anyway, does it break any related
>> functionality?
> I was expecting it to break --compose, but it didn't because in there
> we were using $initial_subject directly instead.

Right, ok.

> AFAIK; I couldn't see a difference eitherway, but as Peff pointed out
> it doesn't make sense leaving it only as a global so just found
> instead a more useful place for it to be reset in the loop, which also
> "fix" another issue of mine.

Well, this only "sometimes" resets it (from a control flow perspective), which is exactly what I tried to avoid globally. Can we somehow agree on something? Because I'd like to submit my patch asap.

Best regards, Marvin