Re: [RFC PATCH] send-email: allow fixing the cover letter subject

From: Carlo Arenas <carenas@gmail.com>
Date: Aug 24, 2021, 16:11 UTC
Message-ID: <CAPUEspgmKPhbPGs+ujy7KVJCyNxS95ph2Dwvd7A7cH2J0em20g@mail.gmail.com>
In-Reply-To: <5a38e420-eea3-a5f2-38c5-64682bd1ba2e@posteo.de>

On Tue, Aug 24, 2021 at 8:19 AM Marvin Häuser <mhaeuser@posteo.de> wrote:

Show 11 quoted lines

> On 24/08/2021 13:41, Carlo Marcelo Arenas Belón wrote:
> > @@ -1719,7 +1719,6 @@ sub process_file {
> >       @xh = ();
> >       my $input_format = undef;
> >       my @header = ();
> > -     $subject = $initial_subject;
>
> This change from my patch is still controversial, and I'd rather not
> submit the addition if it's immediately removed again.
> Why are you dropping it here anyway, does it break any related
> functionality?

I was expecting it to break --compose, but it didn't because in there we were using $initial_subject directly instead.

AFAIK; I couldn't see a difference eitherway, but as Peff pointed out it doesn't make sense leaving it only as a global so just found instead a more useful place for it to be reset in the loop, which also "fix" another issue of mine.

As pointed out in my original email; it doesn't fix the whole problem though, because you still want to edit the rest of the cover letter (could use --annotate for that though), but at least it is less awkward than the current situation, where you will get the series submission aborted because of an incorrect subject, even if a correct one was provided and ended up being ignored.

Carlo

Carlo