Re: [RFC PATCH] send-email: allow fixing the cover letter subject

From: Carlo Arenas <carenas@gmail.com>
Date: Aug 26, 2021, 10:58 UTC
Message-ID: <CAPUEspga0yGn-u-7poRQZomJPAH43AHyegd=chR_z+3gxRxVdw@mail.gmail.com>
In-Reply-To: <e781b15c-8c59-9827-b052-ebe971b01cad@posteo.de>

On Tue, Aug 24, 2021 at 11:31 PM Marvin Häuser <mhaeuser@posteo.de> wrote:

Show 9 quoted lines

> On 24/08/2021 18:11, Carlo Arenas wrote:
> > On Tue, Aug 24, 2021 at 8:19 AM Marvin Häuser <mhaeuser@posteo.de> wrote:
> >> On 24/08/2021 13:41, Carlo Marcelo Arenas Belón wrote:
> >>> @@ -1719,7 +1719,6 @@ sub process_file {
> >>>        @xh = ();
> >>>        my $input_format = undef;
> >>>        my @header = ();
> >>> -     $subject = $initial_subject;
> Can we somehow agree on something? Because I'd like to submit my patch asap.

I think you are correct, and from a flow point of view it should be reset there with the rest. Adding something to the commit message to explain it might help, and the documentation path I suggested (or something better) might be worth squashing to better explain why the last test case that resets in-reply-to headers is correct.

Carlo