git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-stash: Display help message if git-stash is run without sub-commands

From
KLKevin Leung <kevinlsk@gmail.com>
Date
Nov 30, 2007, 08:16 UTC
Message-ID
<e66701d40711300016v15700deft3d262d75a9055aca@mail.gmail.com>

The current git-stash behaviour is very error prone to typos. For example, if you typed "git-stash llist", git-stash would thought that you wanted to save to a stash named "llist", but in fact, you meant "git-stash list".

Signed-off-by: Kevin Leung <kevinlsk@gmail.com>
---
 git-stash.sh |   15 ++++++---------
 1 files changed, 6 insertions(+), 9 deletions(-)
diff --git a/git-stash.sh b/git-stash.sh
index 77c9421..dbb8894 100755
--- a/git-stash.sh
+++ b/git-stash.sh
@@ -1,7 +1,7 @@
 #!/bin/sh
 # Copyright (c) 2007, Nanako Shiraishi

-USAGE='[ | list | show | apply | clear]'
+USAGE='[ save | list | show | apply | clear ]'

 SUBDIRECTORY_OK=Yes
 . git-sh-setup
@@ -195,6 +195,10 @@ show)
        shift
        show_stash "$@"
        ;;
+save)
+       shift
+       save_stash "$@" && git-reset --hard
+       ;;
 apply)
        shift
        apply_stash "$@"
@@ -202,14 +206,7 @@ apply)
 clear)
        clear_stash
        ;;
-help | usage)
-       usage
-       ;;
 *)
-       if test $# -gt 0 && test "$1" = save
-       then
-               shift
-       fi
-       save_stash "$*" && git-reset --hard
+       usage
        ;;
 esac
-- 
1.5.3.6.36.g38762
Next: Mike Hommey
Message 1 of 7 in “git-stash: Display help message if git-stash is run without sub-commands”
  1. git-stash: Display help message if git-stash is run without sub-commandsKevin Leung, Nov 30, 2007
  2. Mike HommeyNov 30, 2007
  3. Kevin LeungNov 30, 2007
  4. Wincent ColaiutaNov 30, 2007
  5. Junio C HamanoNov 30, 2007
  6. David KastrupNov 30, 2007
  7. Johannes SchindelinNov 30, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.