Re: [PATCH 0/2] git-gui: Auto-rescan on activate

From: Johannes Sixt <j6t@kdbg.org>
Date: Dec 17, 2020, 19:45 UTC
Message-ID: <e5f6753b-10b3-1291-1b39-34af63792037@kdbg.org>
In-Reply-To: <20201101170505.71246-1-stefan@haller-berlin.de>

Am 01.11.20 um 18:05 schrieb Stefan Haller:

Show 13 quoted lines

> Do an automatic rescan whenever the git-gui window receives focus. Most other
> GUI tools do this, and it's very convenient; no more pressing F5 manually.
> 
> People who don't like this behavior can turn it off using
> "git config gui.autorescan false".
> 
> Stefan Haller (2):
>   git-gui: Delay rescan until idle time
>   git-gui: Auto-rescan on activate
> 
>  git-gui.sh | 26 ++++++++++++++++++++++----
>  1 file changed, 22 insertions(+), 4 deletions(-)
>

I've been using these patches in the past days.

I am still a bit ambivalent on whether I like the behavior. I do switch among windows *a lot* and there is a short flicker on every rescan. And there is muscle memory...

I observe a bug and a half:

It is unclear which file is selected automatically when there are unstaged changes. But there is one misbehavior: after I have invoked the merge tool, resolved the conflict, and then switch back to Git GUI, the conflicted file is not selected anymore when it is not the first file in the list. That is *very* annoying.

And then there is the following use-case. While Git GUI is not active (think Git GUI and Gitk side-by-side and Gitk active), I click on a particular file that is not at the top of the list; then Git GUI becomes active and rescans, but also forgets on which file I have clicked. But I expected the clicked-on file to become visible, which it doesn't, and I have to click again. This is mildly annoying.

-- Hannes