Re: [PATCH 2/2] git-gui: Auto-rescan on activate

From: Pratyush Yadav <me@yadavpratyush.com>
Date: Nov 2, 2020, 15:48 UTC
Message-ID: <20201102154815.4incizurpmdhhmjh@yadavpratyush.com>
In-Reply-To: <20201101170505.71246-3-stefan@haller-berlin.de>

Hi Stefan,

On 01/11/20 06:05PM, Stefan Haller wrote:

Show 20 quoted lines

> Do an automatic rescan whenever the git-gui window receives focus. Most other
> GUI tools do this, and it's very convenient; no more pressing F5 manually.
> 
> People who don't like this behavior can turn it off using
> "git config gui.autorescan false".
> 
> Signed-off-by: Stefan Haller <stefan@haller-berlin.de>
> ---
>  git-gui.sh | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/git-gui.sh b/git-gui.sh
> index 8864c14..4a4ac19 100755
> --- a/git-gui.sh
> +++ b/git-gui.sh
> @@ -906,6 +906,7 @@ set font_descs {
>  }
>  set default_config(gui.stageuntracked) ask
>  set default_config(gui.displayuntracked) true
> +set default_config(gui.autorescan) true

Default to false. See my reply to the cover letter for more info.

It would also be a good idea to include an option for this in the options dialog. Check do_options in lib/options.tcl for examples.

Show 11 quoted lines

>  
>  ######################################################################
>  ##
> @@ -4020,6 +4021,10 @@ bind .   <Alt-Key-2> {focus_widget $::ui_index}
>  bind .   <Alt-Key-3> {focus $::ui_diff}
>  bind .   <Alt-Key-4> {focus $::ui_comm}
>  
> +if {[is_config_true gui.autorescan]} {
> +	bind .   <FocusIn>  schedule_rescan
> +}
> +

Ok.

Show 6 quoted lines

>  set file_lists_last_clicked($ui_index) {}
>  set file_lists_last_clicked($ui_workdir) {}
>  
> -- 
> 2.29.2
>

-- 
Regards,
Pratyush Yadav