Re: [PATCH 0/2] git-gui: Auto-rescan on activate

From: Pratyush Yadav <me@yadavpratyush.com>
Date: Nov 2, 2020, 13:15 UTC
Message-ID: <20201102131522.coj5gb2bssvjqngo@yadavpratyush.com>
In-Reply-To: <20201101170505.71246-1-stefan@haller-berlin.de>

Hi Stefan,

On 01/11/20 06:05PM, Stefan Haller wrote:

> Do an automatic rescan whenever the git-gui window receives focus. Most other
> GUI tools do this, and it's very convenient; no more pressing F5 manually.

I submitted a patch for this a while back but there was a lengthy 
discussion. [0] would be a good read. IIRC the major blocker was that 
rescan is a very expensive operation on Windows.

> People who don't like this behavior can turn it off using
> "git config gui.autorescan false".

To make sure the experience on Windows (and for anyone who faces long 
rescan times) does not degrade, I think we should keep this off by 
default. That said, I would love to be convinced to keep this on by 
default because IMO this is a really good feature to have. I tried 
coming up with ways to avoid slowdowns while keeping the auto rescan on 
but I didn't come up with anything convincing.

Show 7 quoted lines

> Stefan Haller (2):
>   git-gui: Delay rescan until idle time
>   git-gui: Auto-rescan on activate
> 
>  git-gui.sh | 26 ++++++++++++++++++++++----
>  1 file changed, 22 insertions(+), 4 deletions(-)
>

[0] https://lore.kernel.org/git/20190728151726.9188-1-me@yadavpratyush.com/

-- 
Regards,
Pratyush Yadav