Re: [PATCH] Avoid to duplicate commit message when is not encoded

From: Marco Costalba <mcostalba@gmail.com>
Date: Jul 22, 2007, 22:04 UTC
Message-ID: <e5bfff550707221504g395580e6jdde1f37a810302f0@mail.gmail.com>
In-Reply-To: <7v4pjwssp0.fsf@assigned-by-dhcp.cox.net>

On 7/22/07, Junio C Hamano <gitster@pobox.com> wrote:

Show 9 quoted lines

> Alex Riesen <raa.lkml@gmail.com> writes:
>
> > Marco Costalba, Sun, Jul 22, 2007 10:23:05 +0200:
> >> +            if (encoding) // we'll strip encoding header later
> >
> > You better avoid using C++ comments, not all C compilers support them.
>
> I've "fixed" them.
>

Sorry, I wrote them automatically without thinking it is better to avoid them in C. BTW I would think it's more about coding style then compiler support.

Show 9 quoted lines

> >> +            else
> >> +                    return NULL; // nothing to do
> >
> > And you better avoid such useless comments too
>
> I think this one is probably a good-to-have.  It really needs a
> bit of thinking why there is nothing to do in this case.  At
> least for me it did ;-)
>

Me too ;-)