threads / patch / 9134

patchAvoid to duplicate commit message when is not encoded

Subject: [PATCH] Avoid to duplicate commit message when is not encoded

## tl;dr

5 messages between Jul 22, 2007 and Jul 22, 2007. Diffs are folded; open one to read it.

replies: 4people: 3as markdown or json

Marco Costalba· Jul 22, 2007, 08:23 UTC · lore

When a commit message doesn't have encoding information and encoding output is utf-8 (default) then an useless xstrdup() of commit message is done.

If we assume most of users live in an utf-8 world, this useless copy is the common case.

Performance issue found with KCachegrind.
Signed-off-by: Marco Costalba <mcostalba@gmail.com>
---
 commit.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
Show changes to commit.c +4 −1
diff --git a/commit.c b/commit.c
index 4c5dfa9..ba8413b 100644
--- a/commit.c
+++ b/commit.c
@@ -721,7 +721,10 @@ static char *logmsg_reencode(const
 	encoding = get_header(commit, "encoding");
 	use_encoding = encoding ? encoding : utf8;
  	if (!strcmp(use_encoding, output_encoding))
-		out = xstrdup(commit->buffer);
+		if (encoding) // we'll strip encoding header later
+			out = xstrdup(commit->buffer);
+		else
+			return NULL; // nothing to do
 	else
 		out = reencode_string(commit->buffer,
 				      output_encoding, use_encoding);

-- 
1.5.3.rc2.23.g4c77-dirty
Alex Riesen· Jul 22, 2007, 08:52 UTC · re: Marco Costalba · lore

Re: [PATCH] Avoid to duplicate commit message when is not encoded

Marco Costalba, Sun, Jul 22, 2007 10:23:05 +0200:
> +		if (encoding) // we'll strip encoding header later
You better avoid using C++ comments, not all C compilers support them.
> +		else
> +			return NULL; // nothing to do
And you better avoid such useless comments too
Junio C Hamano· Jul 22, 2007, 09:17 UTC · re: Alex Riesen · lore

Re: [PATCH] Avoid to duplicate commit message when is not encoded

Alex Riesen <raa.lkml@gmail.com> writes:
> Marco Costalba, Sun, Jul 22, 2007 10:23:05 +0200:
>> +		if (encoding) // we'll strip encoding header later
>
> You better avoid using C++ comments, not all C compilers support them.
I've "fixed" them.
>> +		else
>> +			return NULL; // nothing to do
>
> And you better avoid such useless comments too

I think this one is probably a good-to-have. It really needs a bit of thinking why there is nothing to do in this case. At least for me it did ;-)

Marco Costalba· Jul 22, 2007, 22:04 UTC · re: Junio C Hamano · lore

Re: [PATCH] Avoid to duplicate commit message when is not encoded

On 7/22/07, Junio C Hamano <gitster@pobox.com> wrote:
Show 9 quoted lines
> Alex Riesen <raa.lkml@gmail.com> writes:
>
> > Marco Costalba, Sun, Jul 22, 2007 10:23:05 +0200:
> >> +            if (encoding) // we'll strip encoding header later
> >
> > You better avoid using C++ comments, not all C compilers support them.
>
> I've "fixed" them.
>

Sorry, I wrote them automatically without thinking it is better to avoid them in C. BTW I would think it's more about coding style then compiler support.

Show 9 quoted lines
> >> +            else
> >> +                    return NULL; // nothing to do
> >
> > And you better avoid such useless comments too
>
> I think this one is probably a good-to-have.  It really needs a
> bit of thinking why there is nothing to do in this case.  At
> least for me it did ;-)
>
Me too ;-)

← back to recent threads