git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Avoid to duplicate commit message when is not encoded

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 22, 2007, 09:17 UTC
Message-ID
<7v4pjwssp0.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<20070722085225.GB3408@steel.home>
Alex Riesen <raa.lkml@gmail.com> writes:
> Marco Costalba, Sun, Jul 22, 2007 10:23:05 +0200:
>> +		if (encoding) // we'll strip encoding header later
>
> You better avoid using C++ comments, not all C compilers support them.
I've "fixed" them.
>> +		else
>> +			return NULL; // nothing to do
>
> And you better avoid such useless comments too

I think this one is probably a good-to-have. It really needs a bit of thinking why there is nothing to do in this case. At least for me it did ;-)

Previous: Alex RiesenNext: Marco Costalba
Message 4 of 5 in “Avoid to duplicate commit message when is not encoded”
  1. Avoid to duplicate commit message when is not encodedMarco Costalba, Jul 22, 2007
  2. Junio C HamanoJul 22, 2007
  3. Alex RiesenJul 22, 2007
  4. Junio C HamanoJul 22, 2007
  5. Marco CostalbaJul 22, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.