Re: [PATCH] Avoid to duplicate commit message when is not encoded
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 22, 2007, 09:17 UTC
- Message-ID
- <7v4pjwssp0.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <20070722085225.GB3408@steel.home>
Alex Riesen <raa.lkml@gmail.com> writes:
> Marco Costalba, Sun, Jul 22, 2007 10:23:05 +0200: >> + if (encoding) // we'll strip encoding header later > > You better avoid using C++ comments, not all C compilers support them.
I've "fixed" them.
>> + else >> + return NULL; // nothing to do > > And you better avoid such useless comments too
I think this one is probably a good-to-have. It really needs a bit of thinking why there is nothing to do in this case. At least for me it did ;-)