git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix "git log --parent -m" from emitting duplicated parent info

From
MCMarco Costalba <mcostalba@gmail.com>
Date
Jul 9, 2007, 05:46 UTC
Message-ID
<e5bfff550707082246k39286517o58fe89d80e05e08@mail.gmail.com>
In-Reply-To
<7vps32xsof.fsf@assigned-by-dhcp.cox.net>
On 7/9/07, Junio C Hamano <gitster@pobox.com> wrote:
Show 5 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> Second try, this time not doing the simplification when --full-history
> is given.
>

Probably I'm wrong but I would think the first original version with post-filtering is more correct.

Indeed we can use and _do_ use --full-history not only for printing all revisions but to _walk_ the tree in a certain way, different from default.

IMHO --parents + --full-history is absolutely legal because the first flag indicate how to walk the tree and the second flag indicate what to show to the user.

I agree the original patch is much uglier then your last version but I would say is more correct.

Thanks Marco

Previous: Junio C HamanoNext: Junio C Hamano
Message 9 of 10 in “Fix "git log --parent -m" from emitting duplicated parent info”
  1. Fix "git log --parent -m" from emitting duplicated parent infoMarco Costalba, Jul 8, 2007
  2. Junio C HamanoJul 8, 2007
  3. Junio C HamanoJul 9, 2007
  4. Johannes SchindelinJul 9, 2007
  5. Junio C HamanoJul 9, 2007
  6. Junio C HamanoJul 9, 2007
  7. Johannes SchindelinJul 9, 2007
  8. Junio C HamanoJul 9, 2007
  9. Marco CostalbaJul 9, 2007
  10. Junio C HamanoJul 9, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.