From: Marco Costalba <mcostalba@gmail.com>
Date: Mon, 09 Jul 2007 05:46:10 GMT
Subject: Re: [PATCH] Fix "git log --parent -m" from emitting duplicated parent info
Message-ID: <e5bfff550707082246k39286517o58fe89d80e05e08@mail.gmail.com>
In-Reply-To: <7vps32xsof.fsf@assigned-by-dhcp.cox.net>

On 7/9/07, Junio C Hamano <gitster@pobox.com> wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> Second try, this time not doing the simplification when --full-history
> is given.
>

Probably I'm wrong but I would think the first original version with
post-filtering is more
correct.

Indeed we can use and _do_ use --full-history not only for printing
all revisions but to _walk_ the tree in a certain way, different from
default.

IMHO --parents + --full-history is absolutely legal because the first
flag indicate how to walk the tree and the second flag indicate what
to show to the user.

I agree the original patch is much uglier then your last version but I
would say is more correct.

Thanks
Marco