Re: [PATCH] Fix "git log --parent -m" from emitting duplicated parent info

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 8, 2007, 18:32 UTC
Message-ID: <7v4pke3fx0.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <e5bfff550707080737j56c161bdrf0c079b61877085b@mail.gmail.com>

"Marco Costalba" <mcostalba@gmail.com> writes:

Show 10 quoted lines

> Without this patch in case of a merge, duplicated parents are
> omitted in first line output, but still listed in following
> parents information.
>
> Signed-off-by: Marco Costalba <mcostalba@gmail.com>
> ---
>
> Following the hint of someone I submit this patch.
>
> Please take it as a wish of not reverting the patch ;-)

Sorry, I am puzzled... which patch are you talking about possibly getting reverted?

In any case, the caller asked "log" to:

 1. simplify the history, by giving pathspec,
 2. show the list of parents,
 3. show the diff with each of the parents.

If we omit dupilicated parents in the simplified view from 2., we should be consistent in the output from 3.; I think what your patch does makes sense.

I'll look at it again later.