Re: [StGIT RFC PATCH] Don't use refs/bases/<branchname>

From: Marco Costalba <mcostalba@gmail.com>
Date: May 1, 2007, 09:10 UTC
Message-ID: <e5bfff550705010210i352ac9eej6ff7a78aae6535c9@mail.gmail.com>
In-Reply-To: <b0943d9e0705010137q4a35f818m7dbbc9d2e77e2fcf@mail.gmail.com>

On 5/1/07, Catalin Marinas <catalin.marinas@gmail.com> wrote:

Show 11 quoted lines

> On 30/04/07, Karl Hasselström <kha@treskal.com> wrote:
> > It's silly to save the stack base in a ref when it can trivially be
> > computed from the bottommost applied patch, if any. (If there are no
> > applied patches, it's simply equal to HEAD.)
>
> The reason I initially had the base ref was to see what's on top of
> the stack when using gitk. I later added refs/patches/<branch>/...
> which are shown by gitk and the base ref would be redundant.
>
> I'm OK with this patch as long as tools like qgit don't rely on this ref.
>

It's OK for me. A recent qgit already filters out content of refs/bases to reduce visual 'noise'.

The only StGit data read directly are patches sha's; qgit walks recursively all the files called "top" under directory tree

           <git dir>/patches/<current branch>

to get sha list of each applied and unapplied patch in one go.

This is much faster then calling "stg id <patch name>" for all the patches.

   Marco