From: Marco Costalba Date: Tue, 01 May 2007 09:10:47 GMT Subject: Re: [StGIT RFC PATCH] Don't use refs/bases/ Message-ID: In-Reply-To: On 5/1/07, Catalin Marinas wrote: > On 30/04/07, Karl Hasselström wrote: > > It's silly to save the stack base in a ref when it can trivially be > > computed from the bottommost applied patch, if any. (If there are no > > applied patches, it's simply equal to HEAD.) > > The reason I initially had the base ref was to see what's on top of > the stack when using gitk. I later added refs/patches//... > which are shown by gitk and the base ref would be redundant. > > I'm OK with this patch as long as tools like qgit don't rely on this ref. > It's OK for me. A recent qgit already filters out content of refs/bases to reduce visual 'noise'. The only StGit data read directly are patches sha's; qgit walks recursively all the files called "top" under directory tree /patches/ to get sha list of each applied and unapplied patch in one go. This is much faster then calling "stg id " for all the patches. Marco