Re: [StGIT RFC PATCH] Don't use refs/bases/<branchname>

From: Karl Hasselström <kha@treskal.com>
Date: May 1, 2007, 18:56 UTC
Message-ID: <20070501185615.GA32727@diana.vm.bytemark.co.uk>
In-Reply-To: <e5bfff550705010210i352ac9eej6ff7a78aae6535c9@mail.gmail.com>

On 2007-05-01 11:10:47 +0200, Marco Costalba wrote:

Show 7 quoted lines

> On 5/1/07, Catalin Marinas <catalin.marinas@gmail.com> wrote:
>
> > I'm OK with this patch as long as tools like qgit don't rely on
> > this ref.
>
> It's OK for me. A recent qgit already filters out content of
> refs/bases to reduce visual 'noise'.

Good.

Show 8 quoted lines

> The only StGit data read directly are patches sha's; qgit walks
> recursively all the files called "top" under directory tree
>
>           <git dir>/patches/<current branch>
>
> to get sha list of each applied and unapplied patch in one go. This
> is much faster then calling "stg id <patch name>" for all the
> patches.

Hmm. These are on my kill list too. :-)

The patch tops are already recorded in refs/patches/<branch>/<patchname> to keep them from being garbage collected, so these top files are redundant. But it isn't _that_ bad, so if removing them would break qgit, I guess I could try to restrain myself. At least all the other metadata is fair game. :-)

(But if I were you, I'd look for the patches under patches/refs anyway; they _have_ to be there to survive garbage collection, so no amount of stgit refactoring will break qgit.)

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle