git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] Remove dead code after direct graph drawing

From
MCMarco Costalba <mcostalba@gmail.com>
Date
Oct 21, 2006, 19:33 UTC
Message-ID
<e5bfff550610211233i1af1c6a5nf2d50a6759dab061@mail.gmail.com>
In-Reply-To
<200610211740.26128.Josef.Weidendorfer@gmx.de>
>
> On the first pass down, the memory increases by around 26 MB,
> which could by correct, as you do setupData() lazy (no idea what
> this function does...).

Populates the list view item and calculates (only calculation not drawing) the graph of the item (see Git::updateLanes() )

> >
> > I'm not sure it depends on your patch though.
>
> Can you compare with/without my patch?
Yes. You are right, I have a memory increase also without your last patch.
>
> How did you check for leaks in the past?
> Did you try valgrind (memcheck or massif)?
>

I tried with valgrind but with little success due to a lot of noise from qt libraries. Perhaps I was not using it right.

Sorry for the noise
Marco
Previous: Josef Weidendorfer
Message 7 of 7 in “Remove dead code after direct graph drawing”
  1. 2/2 Remove dead code after direct graph drawingJosef Weidendorfer, Oct 19, 2006
  2. Josef WeidendorferOct 19, 2006
  3. Marco CostalbaOct 20, 2006
  4. Jakub NarebskiOct 20, 2006
  5. Marco CostalbaOct 21, 2006
  6. Josef WeidendorferOct 21, 2006
  7. Marco CostalbaOct 21, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.