git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] Remove dead code after direct graph drawing

From
JWJosef Weidendorfer <josef.weidendorfer@gmx.de>
Date
Oct 21, 2006, 15:40 UTC
Message-ID
<200610211740.26128.Josef.Weidendorfer@gmx.de>
In-Reply-To
<e5bfff550610202335rcb83ea8mf7ec2dd79ec6dd90@mail.gmail.com>
On Saturday 21 October 2006 08:35, you wrote:
> Josef,
> 
>  I think ther's a leak somewhere.

I am not really sure... I just scrolled up and down through the kernel repo with the page up/down keys (around 34K revisions).

On the first pass down, the memory increases by around 26 MB, which could by correct, as you do setupData() lazy (no idea what this function does...). On the 2nd pass up again, I only get an increase of around 2 MB. That could be other effects, as on further passes, I do not see any change with pure scrolling.

> Checking memory use with ksysguard is see memory use going up
> scrolling up and down also on the same revisions list view subset.
> 
> I'm not sure it depends on your patch though.

Can you compare with/without my patch? I have no idea what could have introduced any leak here. I do not create any new class instance / structures, but only get rid of pixmap creations/deletions.

How did you check for leaks in the past? Did you try valgrind (memcheck or massif)?

Josef
> 
> Marco
> 
>
Previous: Marco CostalbaNext: Marco Costalba
Message 6 of 7 in “Remove dead code after direct graph drawing”
  1. 2/2 Remove dead code after direct graph drawingJosef Weidendorfer, Oct 19, 2006
  2. Josef WeidendorferOct 19, 2006
  3. Marco CostalbaOct 20, 2006
  4. Jakub NarebskiOct 20, 2006
  5. Marco CostalbaOct 21, 2006
  6. Josef WeidendorferOct 21, 2006
  7. Marco CostalbaOct 21, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.